feat: Add forbidden_filename_characters to JSConfig for use in frontend libraries#45374
Merged
Conversation
…tend libraries Add the filename restrictions to our JS config so we can create a common frontend library function to check filename validity (de-duplicate code). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Contributor
Author
|
/backport to stable29 |
GretaD
approved these changes
May 16, 2024
GretaD
left a comment
GretaD
left a comment
Contributor
There was a problem hiding this comment.
looks good, didnt test it
susnux
requested review from
a team,
GretaD,
sorbaugh and
yemkareems
and removed request for
a team,
sorbaugh and
szaimen
May 16, 2024 14:45
ShGKme
approved these changes
May 16, 2024
nickvergessen
removed their request for review
May 16, 2024 14:50
st3iny
approved these changes
May 16, 2024
susnux
enabled auto-merge
May 16, 2024 15:45
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the filename restrictions to our JS config so we can create a common frontend library function to check filename validity (de-duplicate code).
Checklist